Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter which providers should be available to users #14

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Filter which providers should be available to users #14

merged 1 commit into from
Nov 16, 2022

Conversation

iandunn
Copy link
Member

@iandunn iandunn commented Nov 9, 2022

Fixes #4

I went with the simpler approach discussed in that issue, but am open to other ideas

@iandunn iandunn requested a review from dd32 November 9, 2022 21:33
dd32
dd32 approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@dd32 dd32 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach looks good to me, to fix #4.

Confirmed (via wpdirectory.net) that seemingly no other two-factor extenders use a priority >10 for the filter (and have no reason to), so at 99 should be safe here.

@iandunn iandunn mentioned this pull request Nov 16, 2022
Closed
20 tasks
@iandunn iandunn merged commit 516c51e into trunk Nov 16, 2022
@iandunn iandunn deleted the choose-providers branch November 16, 2022 17:42
iandunn added a commit that referenced this pull request Dec 15, 2022
@iandunn
Add navigation between screens
266cea7 
See #14
@iandunn iandunn added this to the MVP milestone Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dd32 dd32 dd32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MVP
Development

Successfully merging this pull request may close these issues.

Limit available providers
2 participants
@iandunn @dd32