Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix rendering callout blocks as notice blocks" #663

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Revert "Fix rendering callout blocks as notice blocks" #663

merged 1 commit into from
Oct 24, 2024

Conversation

adamwoodnz
Copy link
Contributor

@adamwoodnz adamwoodnz commented Oct 24, 2024 •
edited
Loading

Reverts #662

Still issues with infinite loops

@adamwoodnz adamwoodnz merged commit b2dea2b into trunk Oct 24, 2024
2 checks passed
@adamwoodnz adamwoodnz deleted the revert-662-fix/render-callout-as-notice branch October 24, 2024 19:57
adamwoodnz added a commit that referenced this pull request Oct 24, 2024
@adamwoodnz
Revert "Revert "Fix rendering callout blocks as notice blocks (#662)" (…
37c250b 
…#663)"

This reverts commit b2dea2b.
adamwoodnz added a commit that referenced this pull request Oct 24, 2024
@adamwoodnz
Fix rendering callout blocks as notice blocks, again (#664)
cb56c9f 
* Revert "Revert "Fix rendering callout blocks as notice blocks (#662)" (#663)"

This reverts commit b2dea2b.

* Stop running shortcode block content through render_shortcode

* Hide only empty elements which are allowed

Some other empty elements are added via scripts, eg. iframe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adamwoodnz