mirrored from git://develop.git.wordpress.org/
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore view transitions in Twenty Fifteen for post title and featured image specifically #8131
Draft
felixarntz
wants to merge
2
commits into
WordPress:trunk
Choose a base branch
from
felixarntz:experiment/2015-view-transitions-post
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+109
−0
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
@view-transition { | ||
navigation: auto; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91 changes: 91 additions & 0 deletions
91
src/wp-content/themes/twentyfifteen/js/view-transitions.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,91 @@ | ||
if ( !! window.navigation && 'CSSViewTransitionRule' in window ) { | ||
const getParentElement = ( element, selector ) => { | ||
element = element.parentElement; | ||
while ( element && element !== document ) { | ||
if ( ! selector || element.matches( selector ) ) { | ||
return element; | ||
} | ||
} | ||
return null; | ||
}; | ||
|
||
const setTemporaryViewTransitionNames = async ( entries, vtPromise ) => { | ||
for ( const [ element, name ] of entries ) { | ||
if ( ! element ) { | ||
continue; | ||
} | ||
element.style.viewTransitionName = name; | ||
} | ||
|
||
await vtPromise; | ||
|
||
for ( const [ element, _ ] of entries ) { | ||
if ( ! element ) { | ||
continue; | ||
} | ||
element.style.viewTransitionName = ''; | ||
} | ||
}; | ||
|
||
window.addEventListener( 'pageswap', ( e ) => { | ||
if ( e.viewTransition ) { | ||
if ( document.body.classList.contains( 'single' ) ) { | ||
const article = document.querySelectorAll( 'article.post' ); | ||
if ( article.length !== 1 ) { | ||
return; | ||
} | ||
|
||
setTemporaryViewTransitionNames( [ | ||
[ article[ 0 ].querySelector( '.entry-title' ), 'post-title' ], | ||
[ article[ 0 ].querySelector( '.post-thumbnail' ), 'post-thumbnail' ], | ||
], e.viewTransition.finished ); | ||
} else if ( document.body.classList.contains( 'home' ) || document.body.classList.contains( 'archive' ) ) { | ||
const articleLink = document.querySelector( 'article.post a[href="' + e.activation.entry.url + '"]' ); | ||
if ( ! articleLink ) { | ||
return; | ||
} | ||
|
||
const article = getParentElement( articleLink, 'article.post' ); | ||
|
||
setTemporaryViewTransitionNames( [ | ||
[ article.querySelector( '.entry-title' ), 'post-title' ], | ||
[ article.querySelector( '.post-thumbnail' ), 'post-thumbnail' ], | ||
], e.viewTransition.finished ); | ||
} | ||
} | ||
} ); | ||
|
||
window.addEventListener( 'pagereveal', ( e ) => { | ||
if ( ! window.navigation.activation.from ) { | ||
return; | ||
} | ||
|
||
if ( e.viewTransition ) { | ||
if ( document.body.classList.contains( 'single' ) ) { | ||
const article = document.querySelectorAll( 'article.post' ); | ||
if ( article.length !== 1 ) { | ||
return; | ||
} | ||
|
||
setTemporaryViewTransitionNames( [ | ||
[ article[ 0 ].querySelector( '.entry-title' ), 'post-title' ], | ||
[ article[ 0 ].querySelector( '.post-thumbnail' ), 'post-thumbnail' ], | ||
], e.viewTransition.ready ); | ||
} else if ( document.body.classList.contains( 'home' ) || document.body.classList.contains( 'archive' ) ) { | ||
const articleLink = document.querySelector( 'article.post a[href="' + window.navigation.activation.from.url + '"]' ); | ||
if ( ! articleLink ) { | ||
return; | ||
} | ||
|
||
const article = getParentElement( articleLink, 'article.post' ); | ||
|
||
setTemporaryViewTransitionNames( [ | ||
[ article.querySelector( '.entry-title' ), 'post-title' ], | ||
[ article.querySelector( '.post-thumbnail' ), 'post-thumbnail' ], | ||
], e.viewTransition.ready ); | ||
} | ||
} | ||
} ); | ||
} else { | ||
window.console.warn( 'View transitions not loaded as the browser is lacking support.' ); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noamr @bramus Maybe you can help me out here: With this current logic, whenever I click on a link to open a WordPress post that does not have a featured image (
post-thumbnail
) assigned, my browser gets stuck and seems to endlessly load the page.Maybe it's just a simple logic flaw, but I'm not sure what's missing. My
setTemporaryViewTransitionNames
implementation has a condition to skip any elements that arenull
(via! element
), so I would think such a scenario should be covered. But maybe something else is wrong.