Fix tracking events like add_to_cart in WooCommerce integration #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
added
[Type] Bug
westonruter
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| return $configuration; | ||
| } | ||
| add_filter( 'plwwo_configuration', 'plwwo_woocommerce_configure' ); | ||
|
|
||
| plwwo_mark_scripts_for_offloading( | ||
| // Note: 'woocommerce-google-analytics-integration' is intentionally not included because for some reason events like add_to_cart don't get tracked. |
There was a problem hiding this comment.
maybe add a todo to look into why? could be a bug worth raising upstream, or maybe something we can fix.
There was a problem hiding this comment.
Good idea. Done in #1741.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This is a sub-PR of #1686
While testing Web Worker Offloading, I discovered that
add_to_cartevents weren't getting sent to GA when clicking the Add To Cart button. It seems I should not have included thewoocommerce-google-analytics-integrationscript among those which are offloaded because then it's not picking up on the button click event for some reason. Only the initialview_item_listevent was getting sent. So in this PR I've undone that so that theadd_to_cartevent can be sent to GA:Before:
Screen.recording.2024-12-13.15.18.54.webm
After:
Screen.recording.2024-12-13.15.19.56.webm