-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update instructions for ES node replacement #5338
base: main
Are you sure you want to change the base?
Conversation
Full-stack documentation: https://docs.openverse.org/_preview/5338 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. Changed files 🔄: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating!
@@ -394,7 +401,7 @@ or "production". | |||
pass the public IPv4 DNS step from step 3 to the `-l`/`--limit` flag. | |||
|
|||
```bash | |||
just ansible/playbook <env> elasticsearch/sync_config.yml -e apply=true -l <public_ipv4_dns>` | |||
just ansible/playbook <environment> elasticsearch/sync_config.yml -e apply=true -l <public_ipv4_dns> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a good idea to provide the options for environment (<environment(prod/dev)>
, or is it <environment(production/development)>
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes track with our previous experience 👍 .
Description
This PR adds or updates commands for an ES node replacement. We used this document yesterday, and @dhruvkb and I observed it required some changes.
Testing Instructions
Docs are generated automatically. Proofread the updated page using the link provided in the first comment below.
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin