Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Amazon Kindle Embed Title #68716

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

kartikmehta8
Copy link

@kartikmehta8 kartikmehta8 commented Jan 16, 2025

What?

Resolves: #68714

This PR addresses an issue in the Amazon Kindle Embed block where, after embedding a valid URL, the block incorrectly reverts to the default placeholder text instead of showing the correct text.

Why?

This PR is necessary to fix the user experience when embedding Kindle content. Currently, users expect the block to render the embedded preview after entering a valid URL, but the block erroneously displays the default placeholder text, creating confusion and reducing usability.

Testing Instructions

  1. Open a post or page in the WordPress Gutenberg editor.
  2. Add a new block by clicking the "+" button.
  3. Search for and insert the Amazon Kindle Embed block.
  4. Observe the default text in the block:
    • Expected: The block displays Amazon Kindle Embed - "Embed Amazon Kindle content."
  5. Enter a valid Amazon Kindle URL in the URL field and press Enter.
  6. Expected: The block displays Amazon Kindle Embed - "Embed Amazon Kindle content." [SAME]

Screenshots or screencast

Before After
Screenshot 2025-01-16 at 16 38 11 Screenshot 2025-01-16 at 16 39 12
Screenshot 2025-01-16 at 16 38 11 Screenshot 2025-01-16 at 16 38 11

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: kartikmehta8 <kartikmehta@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 16, 2025
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @kartikmehta8! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

Co-authored-by: kartikmehta8 <kartikmehta@git.wordpress.org>
@kartikmehta8 kartikmehta8 force-pushed the fix/amazon-kindle-embed-default-title branch from fdc28e4 to 1b81fa6 Compare January 16, 2025 11:21
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Block] Embed Affects the Embed Block labels Jan 16, 2025
@Mamaduka Mamaduka self-requested a review January 16, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Embed Affects the Embed Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon Kindle Embed Showing Default Title
2 participants