Move html element help messages to the block library utils. #68708
+41
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Code Quality
afercia
requested review from
michalczaplinski,
ajitbohra and
fabiankaegy
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -901 B (-0.05%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
fabiankaegy
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny PR with trivial changes that doesn't need an addociated issue.
What?
While reviewing #68611 I noticed that the help messages for the HTML element setting used for some blocks are duplicated across the blocks. This PR moves the messages to the block-library utils.
Why?
Having all the messages in a centralized place helps maintenance and consistency.
How?
Moved the messages to a utils file and then imported them where needed.
Testing Instructions
Test the following blocks:
Note: the help messages already include the help text for the
<nav>element that is going to be added in #68611Testing Instructions for Keyboard
Screenshots or screencast