RTLCSS Control Directive Fix + Source Maps #68669
Open
+852
−154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes #68364 to allow for the proper use of control directives. It stops the moving of comments and removal of comments from breaking RTLCSS control directives. It also deletes the bundled
rtlcss-webpack-plugin
in favor of this fork I created which has source map support and is written in TypeScript.Why?
RTLCSS control directives use comments and if those comments are removed or moved, this will cause this to not function properly. See #68364 for more information.
How?
The issue is addressed by removing all comments only after RTLCSS control directives are processed. This is done by processing
cssnano
changes through it's proper webpack plugin.Testing Instructions
Build this SCSS code:
RTLCSS control directives will be correctly applied.
Testing Instructions for Keyboard
Not applicable.
Screenshots or screencast
Not applicable.