-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color Gradients: Adjust max-width
for color gradient swatch to accommodate reset
button size
#68626
Color Gradients: Adjust max-width
for color gradient swatch to accommodate reset
button size
#68626
Conversation
max-width
for color gradient swatch to accommodate reset
button sizemax-width
for color gradient swatch to accommodate reset
button size
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Thanks, @yogeshbhutkar! The fix looks good, but I wonder if we should add some space between the label and the "Reset" button. Otherwise, it looks a bit crammed. |
Thank you for the review, @Mamaduka! 🙌 The space between the label and the reset button has been increased by 4px. Further expanding the spacing would compress the label, affecting its readability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @yogeshbhutkar!
What, Why & How?
This PR addresses an issue in the Navigation block's Submenu & Overlay Background color setting, where the text label becomes excessively large (in width). As a result, the Reset button overlaps with the text, disrupting the layout and negatively impacting usability. This overlap makes it difficult for users to interact with the controls effectively.
Testing Instructions
Navigation block
.Screenshots
Closes: #68625