Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Fix typo in history.navigation's function call #68623

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

yogeshbhutkar
Copy link
Contributor

@yogeshbhutkar yogeshbhutkar commented Jan 13, 2025

What, Why and How?

Fixes a typo in the use-navigation-menu-handlers hook that prevents navigation to /navigation and triggers a warning.

Testing Instructions

  1. Navigate to the site editor.
  2. Make sure you have created a Navigation Menu.
  3. Navigate to the Navigation page.
  4. Choose any Navigation Menu and delete it.
  5. Observe, the deletion happens as expected.

Screencast

PR Demo

closes: #68622

@yogeshbhutkar yogeshbhutkar changed the title Navigation: Fix typo in navigation history function call Navigation: Fix typo in history.navigation's function call Jan 13, 2025
@yogeshbhutkar yogeshbhutkar marked this pull request as ready for review January 13, 2025 07:34
Copy link

github-actions bot commented Jan 13, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@yogeshbhutkar
Copy link
Contributor Author

Hi @t-hamano @Mamaduka, could you please review this PR when you have a moment? I believe it resolves a particularly annoying bug. Your feedback would be greatly appreciated!

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jan 13, 2025
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @yogeshbhutkar!

@t-hamano t-hamano added the [Feature] Navigation in Site View Navigation section in the Site Editor when in Site View, offering a way to manage Navigation Menus a label Jan 13, 2025
@Mamaduka Mamaduka added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 13, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 13, 2025
@Mamaduka Mamaduka merged commit 0c42f22 into WordPress:trunk Jan 13, 2025
76 of 77 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.1 milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Navigation in Site View Navigation section in the Site Editor when in Site View, offering a way to manage Navigation Menus a [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation: Deleting an individual Navigation block causes a warning to be displayed
3 participants