Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive Title Block: Refactor settings panel to use ToolsPanel #67915

Merged

Conversation

karthick-murugan
Copy link
Contributor

@karthick-murugan karthick-murugan commented Dec 13, 2024

What?

Part of: #67813

Why?

Archive Title Block code to include ToolsPanel instead of PanelBody.

How?

Refactored Archive Title Block code to include ToolsPanel instead of PanelBody.

Testing Instructions

  • Login to Dashboard
  • Edit any post/ page
  • Add Archive Title block.
  • Check settings panel of the Archive title block and verify the change.

Screenshots or screencast

Before
before_1

After
after_1

Copy link

github-actions bot commented Dec 13, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: karthick-murugan <karthickmurugan@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this initial refactor we should ensure that any controls that were visible before are alway visible after. So we should add the isShownByDefault prop to the TabsPanelItem

CleanShot.2024-12-13.at.15.34.10.mp4

@karthick-murugan
Copy link
Contributor Author

In this initial refactor we should ensure that any controls that were visible before are alway visible after. So we should add the isShownByDefault prop to the TabsPanelItem

CleanShot.2024-12-13.at.15.34.10.mp4

The changes has been updated @fabiankaegy

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the following are expected specifications for the ToolsPanel:

  • Reset action should update the setting value to the default value.
  • hasValue prop should be true when it is not the default value.

Based on this, I have added a few more suggestions.

Additionally, it would be a good idea to add the dropdownMenuProps to ensure that the drop-down menu is positioned on the left (Example).

packages/block-library/src/query-title/edit.js Outdated Show resolved Hide resolved
packages/block-library/src/query-title/edit.js Outdated Show resolved Hide resolved
packages/block-library/src/query-title/edit.js Outdated Show resolved Hide resolved
packages/block-library/src/query-title/edit.js Outdated Show resolved Hide resolved
packages/block-library/src/query-title/edit.js Outdated Show resolved Hide resolved
packages/block-library/src/query-title/edit.js Outdated Show resolved Hide resolved
packages/block-library/src/query-title/edit.js Outdated Show resolved Hide resolved
@karthick-murugan
Copy link
Contributor Author

I think the following are expected specifications for the ToolsPanel:

  • Reset action should update the setting value to the default value.
  • hasValue prop should be true when it is not the default value.

Based on this, I have added a few more suggestions.

Additionally, it would be a good idea to add the dropdownMenuProps to ensure that the drop-down menu is positioned on the left (Example).

Thanks for the detailed feedback @t-hamano. Updated all the changes.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a small suggestion at the end, but it works fine 👍

packages/block-library/src/query-title/edit.js Outdated Show resolved Hide resolved
packages/block-library/src/query-title/edit.js Outdated Show resolved Hide resolved
@t-hamano t-hamano dismissed fabiankaegy’s stale review January 14, 2025 09:22

Because this feedback has been addressed: #67915 (review)

@t-hamano t-hamano added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 14, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 14, 2025
@t-hamano t-hamano merged commit 994bc80 into WordPress:trunk Jan 14, 2025
67 of 68 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.1 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Title Affects the Query Title Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor "Settings" panel of Archive Title block to use ToolsPanel instead of PanelBody
3 participants