-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Archive Title Block: Refactor settings panel to use ToolsPanel #67915
Archive Title Block: Refactor settings panel to use ToolsPanel #67915
Conversation
This reverts commit 63f81c1.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this initial refactor we should ensure that any controls that were visible before are alway visible after. So we should add the isShownByDefault
prop to the TabsPanelItem
CleanShot.2024-12-13.at.15.34.10.mp4
The changes has been updated @fabiankaegy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the following are expected specifications for the ToolsPanel:
- Reset action should update the setting value to the default value.
- hasValue prop should be true when it is not the default value.
Based on this, I have added a few more suggestions.
Additionally, it would be a good idea to add the dropdownMenuProps
to ensure that the drop-down menu is positioned on the left (Example).
Thanks for the detailed feedback @t-hamano. Updated all the changes. |
…d/toolspanel-archive-title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a small suggestion at the end, but it works fine 👍
Because this feedback has been addressed: #67915 (review)
What?
Part of: #67813
Why?
Archive Title Block code to include ToolsPanel instead of PanelBody.
How?
Refactored Archive Title Block code to include ToolsPanel instead of PanelBody.
Testing Instructions
Screenshots or screencast
Before
After