Skip to content

Commit

Permalink
Use the term menu instead of navigation in nav elements labels.
Browse files Browse the repository at this point in the history
  • Loading branch information
afercia committed Jan 15, 2025
1 parent 5a5455c commit e70aa1a
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ export default function useGenerateDefaultNavigationTitle( clientId ) {

const title = area
? sprintf(
// translators: %s: the name of a menu (e.g. Header navigation).
__( '%s navigation' ),
// translators: %s: the name of a menu (e.g. Header menu).
__( '%s menu' ),
area
)
: // translators: 'navigation' as in website navigation.
__( 'Navigation' );
: // translators: 'menu' as in website navigation menu.
__( 'Menu' );

// Determine how many menus start with the automatic title.
const matchingMenuTitleCount = [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ function ScreenRevisions() {
changePage={ setCurrentPage }
totalItems={ revisionsCount }
disabled={ isLoading }
label={ __( 'Global Styles pagination navigation' ) }
label={ __( 'Global Styles pagination' ) }
/>
</div>
) }
Expand Down
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/pagination/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export default function Pagination( {
className,
disabled = false,
buttonVariant = 'tertiary',
label = __( 'Pagination Navigation' ),
label = __( 'Pagination' ),
} ) {
return (
<HStack
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -269,9 +269,7 @@ test.describe( 'Style Revisions', () => {
}
await userGlobalStylesRevisions.openStylesPanel();
await page.getByRole( 'button', { name: 'Revisions' } ).click();
const pagination = page.getByLabel(
'Global Styles pagination navigation'
);
const pagination = page.getByLabel( 'Global Styles pagination' );
await expect( pagination ).toContainText( '1 of 2' );
await pagination.getByRole( 'button', { name: 'Next page' } ).click();
await expect( pagination ).toContainText( '2 of 2' );
Expand Down

0 comments on commit e70aa1a

Please sign in to comment.