Fix: last error from stream_socket_enable_crypto

[zaerl]

What does this PR do?

Fix: #120

What problem does it fix?

See issue.

How to test if it works?

Working unit tests is ok for this. ./vendor/bin/phpunit

[brandonpayton]

This is interesting... we're getting the same unit test failures as you saw here, @zaerl. I'm also not able to reproduce those locally.

From the logs:

Run phpunit tests --testdox
  phpunit tests --testdox
  shell: /usr/bin/bash -e {0}
  env:
    LOCAL_PHP: 8.1-fpm
    PHPUNIT_CONFIG: phpunit.xml.dist
    COMPOSER_PROCESS_TIMEOUT: 0
    COMPOSER_NO_INTERACTION: 1
    COMPOSER_NO_AUDIT: 1
PHP Fatal error:  Uncaught Error: Call to undefined method PHPUnit\Util\Filesystem::classNameToFilename() in /home/runner/.composer/vendor/phpunit/phpunit/src/TextUI/Command.php:495
Stack trace:
#0 /home/runner/.composer/vendor/phpunit/phpunit/src/TextUI/Command.php(408): PHPUnit\TextUI\Command->handlePrinter()
#1 /home/runner/.composer/vendor/phpunit/phpunit/src/TextUI/Command.php(114): PHPUnit\TextUI\Command->handleArguments()
#2 /home/runner/.composer/vendor/phpunit/phpunit/src/TextUI/Command.php(99): PHPUnit\TextUI\Command->run()
#3 /home/runner/.composer/vendor/phpunit/phpunit/phpunit(107): PHPUnit\TextUI\Command::main()
#4 /home/runner/.composer/vendor/bin/phpunit(122): include('...')
#5 {main}

[zaerl]

This is interesting... we're getting the same unit test failures as you saw here, @zaerl. I'm also not able to reproduce those locally.

From the logs:

Run phpunit tests --testdox
  phpunit tests --testdox
  shell: /usr/bin/bash -e {0}
  env:
    LOCAL_PHP: 8.1-fpm
    PHPUNIT_CONFIG: phpunit.xml.dist
    COMPOSER_PROCESS_TIMEOUT: 0
    COMPOSER_NO_INTERACTION: 1
    COMPOSER_NO_AUDIT: 1
PHP Fatal error:  Uncaught Error: Call to undefined method PHPUnit\Util\Filesystem::classNameToFilename() in /home/runner/.composer/vendor/phpunit/phpunit/src/TextUI/Command.php:495
Stack trace:
#0 /home/runner/.composer/vendor/phpunit/phpunit/src/TextUI/Command.php(408): PHPUnit\TextUI\Command->handlePrinter()
#1 /home/runner/.composer/vendor/phpunit/phpunit/src/TextUI/Command.php(114): PHPUnit\TextUI\Command->handleArguments()
#2 /home/runner/.composer/vendor/phpunit/phpunit/src/TextUI/Command.php(99): PHPUnit\TextUI\Command->run()
#3 /home/runner/.composer/vendor/phpunit/phpunit/phpunit(107): PHPUnit\TextUI\Command::main()
#4 /home/runner/.composer/vendor/bin/phpunit(122): include('...')
#5 {main}

I think is just a matter of phpunit version.

[brandonpayton]

I think is just a matter of phpunit version.

@zaerl, this turned out to be a conflict between a global phpunit version and the deps composer installs under ./vendor. I created a PR to explicitly use the vendor/bin/phpunit, and those errors went away.

#123

[brandonpayton]

The fix looks reasonable, but I don't have any experience with this code yet. Is there any place we are clearly testing or exercising the AsyncHttp Client?

[zaerl]

The fix looks reasonable, but I don't have any experience with this code yet. Is there any place we are clearly testing or exercising the AsyncHttp Client?

It is crashing on local with fatal errors sometimes. I don't think we need a unit test for this, just be sure we do not treat a null as an array.

[brandonpayton]

This looks good to me. Thank you!