Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove BlueprintBuilder as a possible runner input type (#98)
### What does this PR do? - removes the possibility of parsing a Blueprint from a BlueprintBuilder ### What problem does it fix? - the BlueprintParser's method parse could accept a BlueprintBuilder object as a potential input which could lead to errors As context: - the only difference between passing a Blueprint and a BlueprintBuilder was that the method `toBlueprint()` was called for the builder, which has little utility - calling the method `toBlueprint()` on a specific instance of the BlueprintBuilder always returns the same instance of a `Blueprint` - this leads to an issue where someone: - creates a builder, - sets some of the variables, - runs the code with success, - sets some more variables, - runs it expecting another blueprint being generated and receives an error. - running the same Blueprint twice greatly confuses the program. In conclusion: - the user expected the builder to generate another instance of a Blueprint, but it just set some values to the first instance. The runner extracted the first instance instead of creating a new one. The explicit source of this particular error will be fixed in another PR, but as an example of what could go wrong: `InvalidArgumentException: Progress cannot go backwards (tried updating to 3.0105460023897 when it already was 3.0157410774586)` ### How to test if it works? - this PR only removes an execution path from the parser
- Loading branch information