-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add face landmark task #12
Conversation
Signed-off-by: vinlemon <vinlemon0@gmail.com>
Signed-off-by: vinlemon <vinlemon0@gmail.com>
Signed-off-by: vinlemon <vinlemon0@gmail.com>
Signed-off-by: vinlemon <vinlemon0@gmail.com>
Signed-off-by: vinlemon <vinlemon0@gmail.com>
Signed-off-by: vinlemon <vinlemon0@gmail.com>
Signed-off-by: vinlemon <vinlemon0@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I am not familiar with the face landmark task, I have a few questions, could you please help me to figure out?
Also, would you like to add a new example under README to show this fantastic feature? |
@vinlemon Could you please provide an example in a markdown file, showing how to use the code to finish a face landmark task? The example can help users get familiar with your code and how to use them much more efficient. Thanks a lot! |
Signed-off-by: vinlemon <vinlemon0@gmail.com>
Signed-off-by: vinlemon <vinlemon0@gmail.com>
Signed-off-by: vinlemon <vinlemon0@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM, but I have a comment about the source of the model.
I notice there are two models for face_landmarker, one from mediapipe-models and the other from mediapipe-tasks. They have different number of outputs.
I think we should stick to one of them.
The script downloads the one from mediapipe-tasks but the one from mediapipe-models is more accessible, since it's on the official website
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @apepkuss PTAL. If everything is good, then let's merge it :-)
Thanks @vinlemon |
Fixes #7
This PR adds the Face Landmark task #7 .
The handling of
output_face_blendshapes
andoutput_facial_transformation_matrixes
is still missing.