Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add face landmark task #12

Merged
merged 10 commits into from
Oct 2, 2024
Merged

Add face landmark task #12

merged 10 commits into from
Oct 2, 2024

Conversation

vinlemon
Copy link
Contributor

@vinlemon vinlemon commented Sep 26, 2024

Fixes #7

This PR adds the Face Landmark task #7 .
The handling of output_face_blendshapes and output_facial_transformation_matrixes is still missing.

vinlemon added 7 commits July 17, 2024 14:19
Signed-off-by: vinlemon <vinlemon0@gmail.com>
Signed-off-by: vinlemon <vinlemon0@gmail.com>
Signed-off-by: vinlemon <vinlemon0@gmail.com>
Signed-off-by: vinlemon <vinlemon0@gmail.com>
Signed-off-by: vinlemon <vinlemon0@gmail.com>
Signed-off-by: vinlemon <vinlemon0@gmail.com>
Signed-off-by: vinlemon <vinlemon0@gmail.com>
Copy link
Member

@hydai hydai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I am not familiar with the face landmark task, I have a few questions, could you please help me to figure out?

scripts/download-models.sh Show resolved Hide resolved
src/tasks/vision/face_landmark/mod.rs Outdated Show resolved Hide resolved
src/tasks/vision/face_landmark/mod.rs Show resolved Hide resolved
src/tasks/vision/face_landmark/mod.rs Show resolved Hide resolved
@hydai
Copy link
Member

hydai commented Sep 26, 2024

Also, would you like to add a new example under README to show this fantastic feature?

@apepkuss
Copy link
Collaborator

@vinlemon Could you please provide an example in a markdown file, showing how to use the code to finish a face landmark task? The example can help users get familiar with your code and how to use them much more efficient. Thanks a lot!

Signed-off-by: vinlemon <vinlemon0@gmail.com>
Signed-off-by: vinlemon <vinlemon0@gmail.com>
Signed-off-by: vinlemon <vinlemon0@gmail.com>
Copy link

@MediosZ MediosZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM, but I have a comment about the source of the model.
I notice there are two models for face_landmarker, one from mediapipe-models and the other from mediapipe-tasks. They have different number of outputs.
I think we should stick to one of them.
The script downloads the one from mediapipe-tasks but the one from mediapipe-models is more accessible, since it's on the official website

src/tasks/vision/face_landmark/builder.rs Show resolved Hide resolved
@vinlemon
Copy link
Contributor Author

@hydai @apepkuss I've updated the README and added a separate file for the example, which should make the face landmark task clear and easy to follow. Let me know if anything else is needed.

Copy link
Member

@hydai hydai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @apepkuss PTAL. If everything is good, then let's merge it :-)

@hydai hydai merged commit 8afdca2 into WasmEdge:main Oct 2, 2024
2 checks passed
@hydai
Copy link
Member

hydai commented Oct 2, 2024

Thanks @vinlemon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Face Mesh request
4 participants