Conditionally import cross-fetch with polyfill - Issue #197 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good and will work, but I think we could probably just remove the polyfill and allow users who need it to load it. This blog post suggests that as well. https://www.builder.io/blog/stop-polyfilling-fetch-in-your-npm-package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow developers to conditionally import the optional polyfill with the cross-fetch package to address issue 197 #197
It is unclear if the entire package cross-fetch with ponyfill caused the issue or the use of polyfill alone, but we could consider testing with disabled polyfill first. The polyfill is only applied in the absence of global fetch.