EmoteCloner: Fix a hang when the sticker/original server is deleted #3087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modal will hang and load infinitely if the server or the sticker was deleted as the API returns "Unknown Sticker" instead of the sticker object for cases like this
splatterxl
reviewed
Jan 2, 2025
Comment on lines
+77
to
+78
| } catch (err) { | ||
| return undefined; |
There was a problem hiding this comment.
Suggested change
| } catch (err) { | |
| return undefined; | |
| } catch { | |
| // do nothing |
Comment on lines
+345
to
+347
| if (sticker === undefined) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (sticker === undefined) { | |
| return; | |
| } | |
| if (!sticker) return; |
Comment on lines
+366
to
+368
| } else { | ||
| return fetchedSticker; | ||
| } |
There was a problem hiding this comment.
Suggested change
| } else { | |
| return fetchedSticker; | |
| } | |
| } | |
| return fetchedSticker; |
Comment on lines
+356
to
+364
| "id": sticker?.id, | ||
| "name": sticker?.name, | ||
| "format_type": sticker?.format_type, | ||
| // Discord has a character limit of at least 1 for tags (aka related emoji) | ||
| "tags": " ", | ||
| "description": "", | ||
| "type": "2", | ||
| "available": true, | ||
| "guild_id": 0 |
There was a problem hiding this comment.
format to have normal key names not in quotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the modal hanging and infinitely loading in cases where the sticker can't be fetched (e.g when it or the server it's from was deleted, general Discord weirdness, etc). Also allows for the sticker to still be cloned.