feat: Add Vencord styles to popout windows #3080
Conversation
src/utils/quickCss.ts
Outdated
| const interval = setInterval(() => { | ||
| if (popoutWindow.document.readyState === "complete") { | ||
| clearInterval(interval); | ||
|
|
||
| const doc = popoutWindow.document; | ||
| const popoutWindowManager = new StyleManager(doc); | ||
|
|
||
| const style = doc.createElement("style"); | ||
| style.id = "vencord-css-core"; | ||
| style.textContent = document.getElementById("vencord-css-core")!.textContent; | ||
| doc.documentElement.appendChild(style); | ||
|
|
||
| popoutWindowManager.init(); | ||
|
|
||
| toggle(Settings.useQuickCss); | ||
| SettingsStore.addChangeListener("useQuickCss", toggle); | ||
| popoutWindow.addEventListener("beforeunload", () => { | ||
| popoutWindowManager.destroy(); | ||
| }); | ||
| } | ||
|
|
||
| SettingsStore.addChangeListener("themeLinks", initThemes); | ||
| SettingsStore.addChangeListener("enabledThemes", initThemes); | ||
| ThemeStore.addChangeListener(initThemes); | ||
| if (elapsed >= maxWait) { | ||
| clearInterval(interval); | ||
| } | ||
|
|
||
| if (!IS_WEB) | ||
| VencordNative.quickCss.addThemeChangeListener(initThemes); | ||
| elapsed += 500; | ||
| }, 500); | ||
| }); |
There was a problem hiding this comment.
Why is there a loop waiting for the document to be ready? Is it not possible to use the document readystatechange event?
There was a problem hiding this comment.
nop, if the styles get instantly added when the event is dispatched they get overwritten by the actual popout html (?) or smth
There was a problem hiding this comment.
nop, if the styles get instantly added when the event is dispatched they get overwritten by the actual popout html (?) or smth
cursed
is it not possible to inject into the head?
is using a MutationObserver a possibility?
There was a problem hiding this comment.
neither worked from my tests, doing sleep(300) and then adding it worked though but im not sure if its any better
|
don't use a class that's terrible |
|
ill try to come up with somthing else then |
|
i came up with something better |
Previously vencord styles and quick css was only getting added to the main window and not popout windows, this fixes it
example
before
after