fix: update TransactionId to be an optional property on pending trans…

…actions
VMelnalksnis · Feb 26, 2023 · 96dd28d · 96dd28d
1 parent 33096ff
commit 96dd28d
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/source/VMelnalksnis.NordigenDotNet/Accounts/BookedTransaction.cs b/source/VMelnalksnis.NordigenDotNet/Accounts/BookedTransaction.cs
@@ -11,6 +11,9 @@ namespace VMelnalksnis.NordigenDotNet.Accounts;
 /// <summary>A transaction that has been booked - posted to an account on the account servicer's books.</summary>
 public record BookedTransaction : Transaction
 {
+	/// <summary>Gets or sets a unique transaction id created by the <see cref="Institution"/>.</summary>
+	public string TransactionId { get; set; } = null!;
+
 	/// <summary>Gets or sets the date when an entry is posted to an account on the account servicer's books.</summary>
 	public LocalDate BookingDate { get; set; }
 

diff --git a/source/VMelnalksnis.NordigenDotNet/Accounts/PendingTransaction.cs b/source/VMelnalksnis.NordigenDotNet/Accounts/PendingTransaction.cs
@@ -2,7 +2,13 @@
 // Licensed under the Apache License 2.0.
 // See LICENSE file in the project root for full license information.
 
+using VMelnalksnis.NordigenDotNet.Institutions;
+
 namespace VMelnalksnis.NordigenDotNet.Accounts;
 
 /// <summary>A transaction that is still pending.</summary>
-public record PendingTransaction : Transaction;
+public record PendingTransaction : Transaction
+{
+	/// <summary>Gets or sets a unique transaction id created by the <see cref="Institution"/>.</summary>
+	public string? TransactionId { get; set; } = null!;
+}
diff --git a/source/VMelnalksnis.NordigenDotNet/Accounts/Transaction.cs b/source/VMelnalksnis.NordigenDotNet/Accounts/Transaction.cs
@@ -6,16 +6,11 @@
 
 using NodaTime;
 
-using VMelnalksnis.NordigenDotNet.Institutions;
-
 namespace VMelnalksnis.NordigenDotNet.Accounts;
 
 /// <summary>Common information for all transactions.</summary>
 public abstract record Transaction
 {
-	/// <summary>Gets or sets a unique transaction id created by the <see cref="Institution"/>.</summary>
-	public string TransactionId { get; set; } = null!;
-
 	/// <summary>Gets or sets the amount transferred in this transaction.</summary>
 	public AmountInCurrency TransactionAmount { get; set; } = null!;
 

diff --git a/tests/VMelnalksnis.NordigenDotNet.Tests.Integration/Accounts/AccountClientTests.cs b/tests/VMelnalksnis.NordigenDotNet.Tests.Integration/Accounts/AccountClientTests.cs
@@ -111,6 +111,7 @@ public async Task GetTransactions_ShouldReturnExpected()
 			pendingTransaction.TransactionAmount.Amount.Should().Be(10m);
 			pendingTransaction.UnstructuredInformation.Should().Be("Reserved PAYMENT Emperor's Burgers");
 			pendingTransaction.ValueDate.Should().Be(currentDate - Period.FromDays(2));
+			pendingTransaction.TransactionId.Should().BeNull();
 
 			var date = currentDate - Period.FromDays(1);
 			var transactionId = $"{date:yyyyMMdd}01927908-1";