Remove code duplication in main workflow #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdbeukel
commented
Sep 21, 2023
added 9 commits
September 21, 2023 12:06
hdbeukel
commented
Sep 28, 2023
added 4 commits
September 28, 2023 13:58
|
TODO:
|
|
Thanks, Herman, for working on this code reduction! All the changes seem fine to me, and also I trust the test, so I don't worry too much about whether they can alter the code ;) thanks to the changes, now it is much more clean and it will be much easier to add new species or new genomes. |
nicomaper
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Thanks, Herman, for working on this code reduction! All the changes seem fine to me, and also I trust the test, so I don't worry too much about whether they can alter the code ;) thanks to the changes, now it is much more clean and it will be much easier to add new species or new genomes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the duplication from the main workflow. Species id is now determined first and then used to compose the input file paths. I still have some questions before we can merge this, see below.