Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): regard volume as unpublished from the node, if node is not found #99

Merged
merged 1 commit into from
Dec 7, 2023
Merged

fix(controller): regard volume as unpublished from the node, if node is not found #99

merged 1 commit into from
Dec 7, 2023

Conversation

peknur
Copy link
Contributor

@peknur peknur commented Dec 7, 2023

This aligns ControllerUnpublishVolume with the spec

If the volume corresponding to the volume_id or the node corresponding to node_id cannot be found by the Plugin and the volume can be safely regarded as ControllerUnpublished from the node, the plugin SHOULD return 0 OK

@peknur peknur merged commit 5d774d9 into main Dec 7, 2023
2 checks passed
@peknur peknur deleted the fix/controller-unpublish-volume-server-not-found branch December 7, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-droid nate-droid nate-droid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peknur @nate-droid