feat(config): added initial keyring support (#83) #350
+49
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for the keyring.
I used zalando/go-keyring because of recent commits on repo (compared to 99designs/keyring).
When I say initial, I mean it's open for discussion and adding more features (create auth command and save it to keyring?).
How it works:
If a username is set and the password is empty, check the keyring for service
upctl
where the username is coming either from the config file or env.This type of logic does not break current.
Problem:
This PR does not read the username from the keyring, so it still needs a username from config or env. Maybe to introduce a config command
--keyring
?For me, it works by using UPCLOUD_USERNAME and creating username/password upctl services on keyring so I can switch easily between accounts without providing passwords.