-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update msg, srv and action files #4
Conversation
587bac8
to
fce2d11
Compare
That was surprisingly few changes compared to our public repository. Is that really all? |
Except for the package name (which I will update in a separate PR) and the license (which we'll need to discuss separately) that's all. |
Update all messages, services and actions to match what will be on the robot controller with Polyscope 10.7
For Humble this is still required.
56ac33e
to
065dd9c
Compare
There were also changes to setdigitaloutput and setanalogoutput services on internal repository - I can't see these changes here. |
As we don't offer those services on the robot controller currently and the driver does not immediately switch to this repo, let's remove those services for now.
Fixed in latest push. |
msg/ToolOutputMode.msg
Outdated
@@ -1,5 +1,5 @@ | |||
std_msgs/Header header | |||
uint8 TOOL_OUPUT=0 | |||
uint8 TOOL_OUTPUT=0 | |||
uint8 TOOL_POWER=1 | |||
uint8 TOOL_SAFE=2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TOOL_SAFE mode should not be exposed publicly now - it will be released with UR15.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just had a talk with embedded, and this mode was there for a while, but just now it starts to be used for safety input on UR15.
It should be removed for now until UR15 is released.
Update all messages, services and actions to match what will be on the robot controller with Polyscope 10.7