Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update msg, srv and action files #4

Merged
merged 8 commits into from
Nov 29, 2024
Merged

Update msg, srv and action files #4

merged 8 commits into from
Nov 29, 2024

Conversation

urfeex
Copy link
Member

@urfeex urfeex commented Nov 14, 2024

Update all messages, services and actions to match what will be on the robot controller with Polyscope 10.7

@michal-milkowski
Copy link
Member

That was surprisingly few changes compared to our public repository. Is that really all?

CMakeLists.txt Show resolved Hide resolved
@urfeex
Copy link
Member Author

urfeex commented Nov 14, 2024

Except for the package name (which I will update in a separate PR) and the license (which we'll need to discuss separately) that's all.

Update all messages, services and actions to match what will be on
the robot controller with Polyscope 10.7
For Humble this is still required.
@michal-milkowski
Copy link
Member

There were also changes to setdigitaloutput and setanalogoutput services on internal repository - I can't see these changes here.

As we don't offer those services on the robot controller currently and
the driver does not immediately switch to this repo, let's remove those
services for now.
@urfeex
Copy link
Member Author

urfeex commented Nov 27, 2024

There were also changes to setdigitaloutput and setanalogoutput services on internal repository - I can't see these changes here.

Fixed in latest push.

@@ -1,5 +1,5 @@
std_msgs/Header header
uint8 TOOL_OUPUT=0
uint8 TOOL_OUTPUT=0
uint8 TOOL_POWER=1
uint8 TOOL_SAFE=2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TOOL_SAFE mode should not be exposed publicly now - it will be released with UR15.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had a talk with embedded, and this mode was there for a while, but just now it starts to be used for safety input on UR15.
It should be removed for now until UR15 is released.

@urfeex urfeex merged commit 2b90986 into master Nov 29, 2024
7 checks passed
@urfeex urfeex deleted the sync_messages branch November 29, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants