-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from Dropbox to Sharepoint (Consumable scripts) #1458
Draft
sakshimohan
wants to merge
12
commits into
master
Choose a base branch
from
sakshi/sharepoint_update_for_consumables_RF
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- note that the location of the files in sharepoint has also been changed
- the units per case are now hard coded in the script - the unit cost is in ResourceFile_costing.xlsx
@tbhallett Should I also drop the |
sakshimohan
commented
Sep 5, 2024
sakshimohan
pushed a commit
that referenced
this pull request
Sep 6, 2024
- this is due to changes in PR #1458
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update the locations of raw consumables files from dropbox to the new sharepoint folder.
In addition, the following updates are made -
ResourceFile_Consumables_availability_small.csv
. This information is used in certain scripts (plotting cost estimates, predicting availability for consumable scenarios) - Previously this was taken from the large consumable availabilityResourceFile_Consumables_availability_and_usage.csv
descriptive_stats.py
,clean_fac_locations.py
Units per case
andUnit_Cost
are dropped fromResourceFile_Consumables_Items_and_Packages.csv
(Following Issue Remove deprecated concept of Consumables Packages #1303)
Pending tasks
ResourceFile_Consumables_Items_and_Packages.csv
so that the definitions are all in one placeIntervention_Pkg_Code
also needs to be dropped fromResourceFile_Consumables_Item_Designations.csv