Skip to content
This repository has been archived by the owner on Mar 11, 2022. It is now read-only.

Module to retrieve Figshare metadata for public deposit (no token) #4

Merged
merged 18 commits into from
Feb 17, 2021
Merged

Module to retrieve Figshare metadata for public deposit (no token) #4

merged 18 commits into from
Feb 17, 2021

Conversation

astrochun
Copy link
Contributor

Fixes #3

  • Add figshare module
  • Change figshare api routing to specify version
  • Update docstrings in figshare module
  • Add main script for uvicorn run
  • Add figshare tests
  • Add python-package GitHub action
  • Simplify python-package GitHub action
  • Fix coverage no data was collected issue
  • Add additional data to figshare_metadata_readme

@astrochun
Add figshare module
68e3c57
@astrochun
Change figshare api routing to specify version
ab6e505
@astrochun
Update docstrings in figshare module
6375bad 
 - Specify return type hint
@astrochun
Add main script for uvicorn run
aedb56c
@astrochun
Add figshare tests
d7c061d 
 - Add pytest config file
 - Add coveragerc file
@astrochun
Add python-package GitHub action
31e66ff
@astrochun
Simplify python-package GitHub action
45cda32 
 - Merge into single job for dependencies
@astrochun
Fix coverage no data was collected issue
b40f5c8 
 - add tests/__init__.py
@astrochun
Add additional data to figshare_metadata_readme
fb6b8b9 
 - article_id
 - Update DOI for full URL
 - preferred_citation
 - license
 - summary
 - references
@astrochun astrochun added this to the v0.1.0 milestone Feb 10, 2021
@astrochun astrochun added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 10, 2021
@astrochun astrochun self-assigned this Feb 10, 2021
damian-romero
damian-romero approved these changes Feb 16, 2021
View reviewed changes
Copy link

@damian-romero damian-romero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good. I tested it manually too. In the future, we might want to add more automatic test cases.

@astrochun
Copy link
Contributor Author

This all looks good. I tested it manually too. In the future, we might want to add more automatic test cases.

Could you clarify what you mean by more automatic tests?
pytest tests will run all existing unit tests.

@astrochun astrochun mentioned this pull request Feb 17, 2021
Open
astrochun
astrochun commented Feb 17, 2021
View reviewed changes
Copy link
Contributor Author

@astrochun astrochun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and ready for to merge

readme_tool/figshare.py Show resolved Hide resolved
@astrochun astrochun merged commit 7eb497a into main Feb 17, 2021
@astrochun astrochun deleted the 03_figshare_metadata branch February 17, 2021 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@damian-romero damian-romero damian-romero approved these changes

Assignees

@astrochun astrochun

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

Module to retrieve Figshare metadata for public deposit (no token)
2 participants
@astrochun @damian-romero