-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Ocean System #385
base: main
Are you sure you want to change the base?
WIP: Ocean System #385
Conversation
Ocean Clipmap looks identical to GeoClipMap. You should just use GeoClipMap to generate a second clipmap. We put it into a separate class so it can be reused. If there are particular custom options you need in the ocean mesh, GeoClipMap can be modified. |
ok I will create a new function in generate_ocean() because it uses skirt mesh and terrain3d's clipmap does not use skirt. |
@anandbarai09 It would be helpful if you could share screenshots |
I'm sure screenshots can wait until Op has something implemented and working. Op, like my comment on GeoClipMap, you're duplicating a lot of classes. That is unnecessary. Change the existing classes or derive from them as needed. Reuse code religiously. Utilize the inheritance model within C++. You can dramatically reduce the amount of code, which will make this PR easier to write and maintain as you get closer to completion. Even the change you made to GeoClipMap is unnecessary. You don't need to duplicate an entire function just so you can have skirts. Instead add a parameter to the function and add skirts if that parameter is true. Your 400 lines of changes to this class will be reduced down to 20. |
I am curious if this is still something that is being worked on / considered / implemented for Terrain3D? I have been using Terrain3D for a concept I am prototyping and an ocean addition like this would likely affect my end process. If not I totally understand and may look at the work done here in the future (likely months down the road as I am doing this prototype in my free time) and try to contribute back if the system is not in when / if I get to that stage! For now I will continue with my efforts at using noise. Thanks for the incredible system you have created here by the way! |
@backlands This is a PR. Follow #298 for a better discussion. You should plan on making a large plane with an ocean shader until if and when a tangible solution is implemented. |
Thanks for pointing that discussion out, it wasn't linked here so I missed it when looking around. I currently have the water shader and am using a noise method to drop the bottom of terrain below 0. I'll read the discussion and get up to speed on what is planned there once I have a chance. |
Todo
Ocean Shader(In Progress, Current Shader is not good looking and has many problems),
Ocean Physics.
Done :
Ocean Clipmap
Ocean3D (Ocean3d node , Ocean3DStorage, Ocean3DMaterial) (will require some cleanup)