Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the base tracker profiles to use the tracker images. #39

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

LiminalityCarb
Copy link

The tracker images for Bored and WTF were added in a previous version, but were never added to the tracker profile. This commit includes adding use of the Bored and WTF images for some responses where it felt appropriate. Default profile does not use it, but mostly the "Rated T for Teen" and "Sassy" had locations that it felt appropriate (as well as a few areas in the BCU profile)

The tracker images for Bored and WTF were added in a previous version, but were never added to the tracker profile.  This commit includes adding use of the Bored and WTF images for some responses where it felt appropriate.
@MattEqualsCoder
Copy link
Contributor

Yeah, when I coded this feature, I didn't have time to go through and add it to a bunch a lines, so I appreciate this!

A couple things, though. First, can you delete the WTF and Bored images for the Halloween (and maybe Christmas?) profiles since we don't have those sprites for those profiles.

Then, I guess after that, can you make sure it doesn't blow up without them? It should fall back to the default talking sprites, but I haven't tested it since I originally implemented it.

@LiminalityCarb
Copy link
Author

Yeah, when I coded this feature, I didn't have time to go through and add it to a bunch a lines, so I appreciate this!

A couple things, though. First, can you delete the WTF and Bored images for the Halloween (and maybe Christmas?) profiles since we don't have those sprites for those profiles.

Then, I guess after that, can you make sure it doesn't blow up without them? It should fall back to the default talking sprites, but I haven't tested it since I originally implemented it.

Will do, I'll get to this in the morning and test.

Removed the Halloween WTF and Bored sprites. When they would be used, as they don't exist the system just uses the default pose instead (EG: default Halloween idle/talk. Not default WTF_idle/talk)

Also added the Christmas sprites as an option to match how the Halloween sprites can still be selected after the holiday has ended.
@LiminalityCarb
Copy link
Author

When using the holiday specific ones and a WTF/Bored line attempts to be used, the system still works. Due to not finding the Bored/WTF images, it just remains using the Default Idle/Talk for the holiday that was selected. So tracker doesn't suddenly revert to normal when using the holiday modes. (May want to reach out to the artist later to ask/commission them to do the additional versions for future years though?)

@MattEqualsCoder
Copy link
Contributor

Yeah, I didn't for this year just to make it easier to get them done in time, but I do need to reach out and see about getting the other poses.

@MattEqualsCoder MattEqualsCoder merged commit 02586c0 into TheTrackerCouncil:main Jan 6, 2025
1 check passed
@MattEqualsCoder
Copy link
Contributor

@LiminalityCarb This is just an FYI, but you might notice I put in an update to delete the tracker sprites. I didn't think of it, but with the new release that should be out today barring any issues releasing the multiworld server (or maybe even if there are), tracker sprites are managed separately in this repo: https://github.com/TheTrackerCouncil/TrackerSprites

(I still need to write up a readme and put in a description. Whoops.)

@LiminalityCarb
Copy link
Author

Sorry for my misunderstanding. since they were there for Halloween as a tracker profile i made an assumption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants