feat: add burst balloons problem #2749
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codec404
requested review from
Panquesito7 and
realstealthninja
as code owners
realstealthninja
added
on hold
|
Dynamic programming does not compile at the moment I'll review this soon but trying to get the ci fixed hope you understand |
realstealthninja
changed the title
realstealthninja
requested changes
Oct 4, 2024
Comment on lines
+19
to
+22
| #include <iostream> | ||
| #include <vector> | ||
| #include <cassert> | ||
|
|
There was a problem hiding this comment.
These headers should be documented
| #include <vector> | ||
| #include <cassert> | ||
|
|
||
| using namespace std; |
There was a problem hiding this comment.
Suggested change
| using namespace std; |
| int expected_result3 = 9; // Expected output | ||
| int result3 = dynamic_programming::burst_balloons::maxCoins(nums3); | ||
| assert(result3 == expected_result3); | ||
| cout << "Test 3 passed: Maximum coins = " << result3 << endl; |
There was a problem hiding this comment.
Add empty and negative test cases or use uint32_t as the parameter type
realstealthninja
added
awaiting modification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR implements the Burst Balloons problem using dynamic programming and memoization, encapsulated within the dynamic_programming::burst_balloons namespace. The algorithm maximizes coins obtained by strategically bursting balloons. Test cases based on the problem statement have been added to ensure correctness.
Checklist
Notes:
This implementation addresses an optimal solution for the Burst Balloons problem (example inputs provided in test cases). It uses memoization to avoid recalculating overlapping subproblems and follows proper documentation practices using Doxygen-style comments.
This submission is intended to enhance the library’s dynamic programming section.