chore: enable slither

TempleDAO · Oct 21, 2023 · 571315b · 571315b
1 parent 24f43df
commit 571315b
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 2 deletions.
diff --git a/.github/workflows/slither.yaml b/.github/workflows/slither.yaml
@@ -10,7 +10,7 @@ on:
       - ".github/workflows/slither.yaml"
 jobs:
   analyze:
-    if: ${{ false }} # Slither has an issue with prb math, and is super slow...
+    # if: ${{ false }} # Slither has an issue with prb math, and is super slow...
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3

diff --git a/protocol/foundry.toml b/protocol/foundry.toml
@@ -8,6 +8,7 @@
   test = 'test/forge'
   cache_path = 'cache-foundry'
   gas_reports = ["*"]
+  evm_version = "paris"           # See https://www.evmdiff.com/features?name=PUSH0&kind=opcode
 
 [profile.ci]
   fuzz = { runs = 5000 }

diff --git a/protocol/slither.db.json b/protocol/slither.db.json
@@ -1,4 +1,14 @@
 [
+  {
+    "elements": [],
+    "description": "solc-0.8.21 is not recommended for deployment\n",
+    "markdown": "solc-0.8.21 is not recommended for deployment\n",
+    "first_markdown_element": "",
+    "id": "d89306001b1fa2ce11230334eb8b32e1ae6da7490b6d2bb2daf2e369120bbacf",
+    "check": "solc-version",
+    "impact": "Informational",
+    "confidence": "High"
+  },
   {
     "elements": [
       {

diff --git a/protocol/test/forge/v2/strategies/RamosStrategy.t.sol b/protocol/test/forge/v2/strategies/RamosStrategy.t.sol
@@ -216,7 +216,7 @@ contract RamosStrategyTestAdmin is RamosStrategyTestBase {
         assertEq(strategy.rescuer(), rescuer);
         assertEq(strategy.apiVersion(), "1.0.0");
         assertEq(strategy.strategyName(), "RamosStrategy");
-        assertEq(strategy.strategyVersion(), "1.0.0");
+        assertEq(strategy.strategyVersion(), "1.0.1");
         assertEq(address(strategy.treasuryReservesVault()), address(trv));
         assertEq(address(strategy.quoteToken()), address(dai));
         ITempleStrategy.AssetBalanceDelta[] memory adjs = strategy.manualAdjustments();