-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use plaintext for connectivity test #9528
Use plaintext for connectivity test #9528
Conversation
By using plaintext for connectivity testing instead of a DB related one we rule out any issues related to the database while checking if the server is up
Please don't touch the toolset.
|
@@ -74,7 +74,7 @@ def is_accepting_requests(self): | |||
|
|||
url = "http://%s:%s%s" % (self.benchmarker.config.server_host, | |||
self.port, | |||
self.runTests[test_type].get_url()) | |||
self.runTests["plaintext"].get_url()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change breaks all tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok then how can I change which test to use for this check for the ReactPHP bench mark?
For run all the tests, start with the db test, and reactphp start to be blocked. Never send a response, not even a 500 error, only show the errors (if configured) in the shell. |
I need to stop with ctrl+c, because is blocked there and the tests reject it after some time. PD: that's before in the run |
Also if the error is for not connect to the database, it'll be good that show that: "Error connecting to the database". And return a 500 error. |
Fair, I'll have a look at fixing that. But I still think, connection tests should use the simplest end point possible to avoid complexity. |
By using plaintext for connectivity testing instead of a DB related one we rule out any issues related to the database while checking if the server is up