added compile_sdk, min_sdk and target_sdk

[shalva97]

Description

Issue tracker

There was 3 different Android SDKs included:

In gradle files, it had different versions per module, so I added it to ext. Now it show only one:

Is there a reason to have SDK versions different for modules? at least for me having it in ext block looks cleaner, also 2 less SDK is loaded by the studio and I think it should be faster

Automatic tests

• Added test cases

Manual tests

• Done

Build tasks success

Successfully running following tasks on local:

• ./gradlew assembledebug
• ./gradlew spotlessCheck

[JeanPaulLucien]

I don't like this code. You creates new variables for nothing.

Amaze use 3rd party librabries. These libraries have own requirements. Change configs is bad idea, because nobody tested libs with all custom configs.

[shalva97]

These libraries have own requirements

Should not we update them? API 28 was released at 2018...

If you look at build.gradle file commits, you will see that their SDKs were never updated, except the root build.gradle.

You creates new variables for nothing.

if there were those variables probably it would be updated long ago. Anyways Im not 100% sure it should be same version accross all modules, but I also want to know why not. For me having less libs showing up in the list pleases my OCD...

[VishnuSanal]

@shalva97 hi, thanks a lot for your contribution! but, this currently has merge conflicts + there aren't any significant benefits to the changes. this will be superseded by #4215 too. we can merge it if you can fix the merge conflicts & the tests pass.

closing this for now; feel free to reopen.