fix: Set book form button initial states and assert

TatuLund · Oct 4, 2024 · 672dd7e · 672dd7e
1 parent baa9c6d
commit 672dd7e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/vaadincreate-ui/src/main/java/org/vaadin/tatu/vaadincreate/crud/form/BookForm.java b/vaadincreate-ui/src/main/java/org/vaadin/tatu/vaadincreate/crud/form/BookForm.java
@@ -115,7 +115,6 @@ public BookForm(BooksPresenter presenter) {
             var hasChanges = binder.hasChanges();
             saveButton.setEnabled(hasChanges && isValid);
             discardButton.setEnabled(hasChanges);
-
         });
 
         saveButton.addClickListener(event -> handleSave());
@@ -330,6 +329,8 @@ public void editProduct(Product product) {
         deleteButton.setEnabled(product.getId() != null);
         currentProduct = product;
         binder.readBean(product);
+        saveButton.setEnabled(false);
+        discardButton.setEnabled(false);
 
         // Scroll to the top
         // As this is not a Panel, using JavaScript

diff --git a/vaadincreate-ui/src/test/java/org/vaadin/tatu/vaadincreate/crud/BooksViewTest.java b/vaadincreate-ui/src/test/java/org/vaadin/tatu/vaadincreate/crud/BooksViewTest.java
@@ -129,6 +129,8 @@ private void verifySelectedCategoriesAreTheFirst() {
     @SuppressWarnings("unchecked")
     public void crossValidationAndDiscard() {
         test($(view, Button.class).id("new-product")).click();
+        assertFalse($(form, Button.class).id("discard-button").isEnabled());
+        assertFalse($(form, Button.class).id("save-button").isEnabled());
 
         test($(form, TextField.class).id("product-name")).setValue("Te");
         test($(form, AvailabilitySelector.class).id("availability"))