Enable Optional Encryption Without CA_Cert #539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds the following enable setting to
config.yaml
Previously encryption was enabled by setting the
ca_cert
value. But this is not necessary if your servers cert is from a trusted authority such as Let's Encrypt.I added a deprecation warning to the documentation, but for the time being if
ca_cert
is set encryption will continue to be enabled even ifenable: False
. This will only affect users who have enabled encryption previously and now attempt to disable it withencryption: False
. Since I suspect basically no one updates their config files with settings that are added in later, I doubt this will ever be an issue.Also encryption seems to be a little used feature.
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: