Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Optional Encryption Without CA_Cert #539

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

krkeegan
Copy link
Collaborator

Proposed change

Adds the following enable setting to config.yaml

mqtt:
  encryption:
    enable: False

Previously encryption was enabled by setting the ca_cert value. But this is not necessary if your servers cert is from a trusted authority such as Let's Encrypt.

I added a deprecation warning to the documentation, but for the time being if ca_cert is set encryption will continue to be enabled even if enable: False. This will only affect users who have enabled encryption previously and now attempt to disable it with encryption: False. Since I suspect basically no one updates their config files with settings that are added in later, I doubt this will ever be an issue.

Also encryption seems to be a little used feature.

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated

Useful if your servers cert is from a trusted source such as
Let's Encrypt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants