This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
RFC-0001 Standard tbDEX API Design (APID) Document v0.1.0 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KendallWeihe
requested review from
nitro-neal,
kirahsapong,
shamilovtim,
diehuxx,
decentralgabe and
frankhinek
as code owners
KendallWeihe
changed the title
nitro-neal
reviewed
Jun 28, 2024
|
|
||
| > [!WARNING] | ||
| > | ||
| > Snake vs camel casing is inconsistent |
There was a problem hiding this comment.
this is because the spec or rust binding stuff?
There was a problem hiding this comment.
just cause move fast
nitro-neal
reviewed
Jun 28, 2024
|
|
||
| > [!WARNING] | ||
| > | ||
| > We need to define `JsonNode` |
There was a problem hiding this comment.
I Will think about this... there must be a idiomatic way
There was a problem hiding this comment.
Right now I'm referencing the Custom DSL over in web5-rs, even though we're inside tbdex-rs. Basically I think we just need to add the concept of a JSON Object type to the Custom DSL and then update this APID and the web5-rs APID to use that new syntax.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See RFC-0001 for full description.