SIP-336 Deploy Synthetix V3 Core on Base #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisekit
force-pushed
the
SIP-336-Deploy-Synthetix-V3-Core-on-Base
branch
from
75b051c to
2fb5551
Compare
noisekit
force-pushed
the
SIP-336-Deploy-Synthetix-V3-Core-on-Base
branch
2 times, most recently
from
de584d0 to
44828eb
Compare
noisekit
force-pushed
the
Base-Goerli
branch
2 times, most recently
from
994ca2c to
4ea55b5
Compare
noisekit
force-pushed
the
SIP-336-Deploy-Synthetix-V3-Core-on-Base
branch
from
44828eb to
29c507f
Compare
noisekit
force-pushed
the
Base-Goerli
branch
from
4ea55b5 to
c756471
Compare
noisekit
force-pushed
the
SIP-336-Deploy-Synthetix-V3-Core-on-Base
branch
from
29c507f to
921f1a9
Compare
noisekit
force-pushed
the
Base-Goerli
branch
from
c756471 to
73927c3
Compare
noisekit
force-pushed
the
SIP-336-Deploy-Synthetix-V3-Core-on-Base
branch
from
921f1a9 to
5e5e034
Compare
0xjocke
reviewed
Sep 7, 2023
noisekit
force-pushed
the
SIP-336-Deploy-Synthetix-V3-Core-on-Base
branch
from
304f9f7 to
978d67c
Compare
noisekit
force-pushed
the
SIP-336-Deploy-Synthetix-V3-Core-on-Base
branch
from
978d67c to
3b27b48
Compare
0xjocke
reviewed
Oct 13, 2023
0xjocke
reviewed
Oct 13, 2023
dbeal-eth
requested changes
Oct 16, 2023
omnibus-base-mainnet.toml
Outdated
| defaultValue = "86400" | ||
|
|
||
| [setting.deployer] | ||
| defaultValue = "0x302d2451d9f47620374B54c521423Bf0403916A2" |
There was a problem hiding this comment.
from our first deployment of v3, the deployer has since changed to 0xEde8a407913A874Dd7e3d5B731AFcA135D30375E
There was a problem hiding this comment.
apply same fix to all other of the same address
There was a problem hiding this comment.
Ok. But I will not touch any other deployments in this pr. Separate pr only
noisekit
changed the title
dbeal-eth
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #37
SIP: https://sips.synthetix.io/sips/sip-336/
Notes:
Simulate release added to github actions and passes OK (tested locally too)
Failing simulate-release is correct because this is the very first deploy and it "modifies" InitialCoreProxy