feat : HCX-964 Implement QR Code Generation #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maheshkumargangula
requested changes
Feb 16, 2024
There was a problem hiding this comment.
This file is not required. Please don't commit this.
hcx-qr-code-generator/pom.xml
Outdated
There was a problem hiding this comment.
Maintain an order when you add dependencies to a POM file.
- Modules implemented within the project.
- External dependencies.
- Test dependencies.
Comment on lines
72
to
77
| MultiFormatWriter writer = new MultiFormatWriter(); | ||
| BitMatrix matrix = writer.encode(content, BarcodeFormat.QR_CODE, 150, 150); | ||
| String currentDir = System.getProperty("user.dir"); | ||
| Path path = FileSystems.getDefault().getPath(currentDir + "/qr_code.png"); | ||
| MatrixToImageWriter.writeToPath(matrix, "PNG", path); | ||
| System.out.println("QR code image generated and saved to: " + path.toAbsolutePath()); |
There was a problem hiding this comment.
- Define a config file and expect these values from configuration.
- Don't use a static name for the QR code image.
| Gson gson = new Gson(); | ||
| Map<String, Object> map = gson.fromJson(json, HashMap.class); | ||
| System.out.println("Map received from command line argument:"); | ||
| generateJWSToken((Map<String, Object>) map.get("payload"), (String) map.get("signingPrivateKey")); |
There was a problem hiding this comment.
Private key shouldn't be a parameter here. It should be a configuration to the tool to use and execute.
| return payload; | ||
| } | ||
|
|
||
| public static Map<String, Object> createVerifiableCredential(Map<String, Object> payload, String proofValue) throws Exception { |
There was a problem hiding this comment.
Please consider using templating engines here.
maheshkumargangula
approved these changes
Feb 19, 2024
maheshkumargangula
approved these changes
Mar 7, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.