-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enabling support for wireguard and firewall #2713
base: next/minor
Are you sure you want to change the base?
Conversation
…ure/wireguard-and-firewall
…ure/wireguard-and-firewall
…ure/wireguard-and-firewall
…ure/wireguard-and-firewall
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Give proofs that things works, that way we can document that we have fixed things, and the new routes in the cli and such work, and we can do what we are fixing.
@@ -4,7 +4,7 @@ set -e | |||
|
|||
# install dependencies | |||
/usr/bin/apt update | |||
/usr/bin/apt install --no-install-recommends -y xserver-xorg x11-xserver-utils xinit firefox-esr matchbox-window-manager libnss3-tools | |||
/usr/bin/apt install --no-install-recommends -y xserver-xorg x11-xserver-utils xinit firefox-esr matchbox-window-manager libnss3-tools p11-kit-modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -83,6 +83,9 @@ user_pref("toolkit.telemetry.updatePing.enabled", false); | |||
user_pref("toolkit.telemetry.cachedClientID", ""); | |||
EOF | |||
|
|||
cp /usr/lib/firefox-esr/libnssckbi.so /usr/lib/firefox-esr/libnssckbi.so.bak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷♀️ why?
"dhcp", | ||
dhcp::dhcp::<C>().with_about("Command to update IP assigned from dhcp"), | ||
) | ||
// .subcommand( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Did you want to leave this commented out?
} | ||
|
||
#[derive(Clone, Default)] | ||
struct LogFile(Arc<Mutex<Option<File>>>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you use this a chance to get to logging to a file. I don't see the downsides, better rotations usually and keeping
fn compat(self) -> &'static VersionRange { | ||
&V0_3_0_COMPAT | ||
} | ||
fn up(self, db: &mut Value, _: Self::PreUpRes) -> Result<(), Error> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proof this was tested?
@@ -7,7 +7,6 @@ export type ServiceInterface = { | |||
id: ServiceInterfaceId | |||
name: string | |||
description: string | |||
hasPrimary: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Kill all bools
This pr refactors the network stack of StartOS. The primary feature is to track the network interfaces that StartOS listens on, and manages what underlying service interfaces to route to based on whether they are private or public
closes #2586
closes #2314