redragon/k552/v2/iso - fix led matrix and via build #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dexter93
requested changes
Oct 5, 2024
sreichholf
force-pushed
the
fix_k552_led_matrix
branch
from
b121559 to
ec262b8
Compare
* there is an actual difference between the keyboard an the led matrix so # was unlit because it was mapped to what was meant to be return fix the matrix (tested on my keyboard after having ignored this for months...) * disable some effects to fix via build (too big with all effects enabled)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the unlit # key and via build (by disabling some matrix effects to make the firmware smaller).
Types of Changes
Issues Fixed or Closed by This PR
Checklist