Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keychron C2 RGB ANSI #426

Merged
merged 9 commits into from
Sep 27, 2024
Merged

Keychron C2 RGB ANSI #426

merged 9 commits into from
Sep 27, 2024

Conversation

JAO1988
Copy link

@JAO1988 JAO1988 commented Sep 26, 2024

Updated older Keychron C2 RGB ANSI code using Aaronsb C1 SN32_Develop code as a primer. Keyboard.json was updated to reflect changes to modern QMK Syntax.

  • Created Keyboard.json
  • Corrected PID & VID USB Designations from Keychron
  • Updated RGB Matrix and Diode Orientation
  • Changes to default/keymap.c file to reflect QMK Keycode changes
  • Adjusted config.h for WIN/MAC Dip Switch Toggle & Sleep
  • !!! VIA compiling is currently broken and has been removed due to EEPROM limitations !!!

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

JAO1988 and others added 8 commits September 26, 2024 03:09
@JAO1988
Updated C2 files with older SN32_Master files in separate folder.
842f268
@JAO1988
Update config.h
552bbf3 
Changed definitions of config.h to match current tree of sn32_develop
@JAO1988
Keychron C2 SN32_Develop Corrections
26fa469 
Removed c2/rgb/old folder as appended files are no longer needed, updated rgb.c with new functions for dip_switch_enable, and updated keymaps with appropriate QMK optimizations and dipswitch toggle function.
@JAO1988
Update rgb.c
d3fad40 
Correction on line 68 - Added ; after false parameter.
@JAO1988
keymap.c, rgb.c sleep LED, config.h optimizations
c2e4e6b 
Corrected and adjusted the appropriate keys for default/via keymap files, corrected and adjusted rgb.c sleep LEDs when power matrix goes to sleep, and removed unnecessary code from config.h.
@JAO1988
Merge branch 'c2_development' of https://github.com/JAO1988/qmk_firmware
4e604c0 
 into c2_development
@JAO1988
Removed VIA code due to EEPROM limits.
db65e13 
Removed, adjusted, and optimized code.
@JAO1988
Update readme.md
a374185 
Added additional comments and changes to manual.
@JAO1988 JAO1988 closed this Sep 26, 2024
@JAO1988 JAO1988 reopened this Sep 26, 2024
dexter93
dexter93 requested changes Sep 27, 2024
View reviewed changes
keyboards/keychron/c2/rgb/rgb.c Outdated Show resolved Hide resolved
@JAO1988 @dexter93
Update keyboards/keychron/c2/rgb/rgb.c
c8ea56b 
Co-authored-by: Dimitris Mantzouranis <d3xter93@gmail.com>
@dexter93 dexter93 merged commit 569f280 into SonixQMK:sn32_develop Sep 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dexter93 dexter93 dexter93 requested changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JAO1988 @dexter93