Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HATOR Gravity X TKL keyboard support #403

Merged
merged 7 commits into from
Sep 22, 2024
Merged

Add HATOR Gravity X TKL keyboard support #403

merged 7 commits into from
Sep 22, 2024

Conversation

AlexHtr
Copy link

@AlexHtr AlexHtr commented Sep 19, 2024

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

dexter93
dexter93 requested changes Sep 20, 2024
View reviewed changes
keyboards/hator/gravity/xtkl/config.h Outdated Show resolved Hide resolved
keyboards/hator/gravity/xtkl/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/hator/gravity/xtkl/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@AlexHtr
fixes
a371cba 
copyright holder fix, config.h edited
@AlexHtr
via and default keymap.c updates
8e35c3a
@AlexHtr AlexHtr requested a review from dexter93 September 20, 2024 12:40
dexter93
dexter93 requested changes Sep 20, 2024
View reviewed changes
Copy link

@dexter93 dexter93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace should be removed.

Also, pull/rebase your branch - lint should pass now

keyboards/hator/gravity/xtkl/readme.md Outdated Show resolved Hide resolved
@AlexHtr AlexHtr requested a review from dexter93 September 20, 2024 14:08
@dexter93 dexter93 merged commit 7d6502b into SonixQMK:sn32_develop Sep 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dexter93 dexter93 Awaiting requested review from dexter93

Assignees
No one assigned
Labels
keyboard keymap via
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexHtr @dexter93