Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keychron C1] Fixed mac keymap, and some code readablitity changes. #398

Merged
merged 31 commits into from
Oct 12, 2024
Merged

[Keychron C1] Fixed mac keymap, and some code readablitity changes. #398

merged 31 commits into from
Oct 12, 2024

Conversation

NetUserGet
Copy link

@NetUserGet NetUserGet commented Sep 14, 2024 •
edited
Loading

User facing changes is that the dipswitch should function as it does in stock firmware as is with the mac keymap.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • The boot-loader key bind now works as intended.
  • Mac keys such as Option and Command should be in their rightful place

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

NetUserGet and others added 29 commits June 29, 2024 15:49
@NetUserGet
Keychron C1 RGB: Inital
d29e8e0
@NetUserGet
Keychron C1 RGB: Mac and Windows Indicator lights
1630ab1
@NetUserGet
Keychron C1 RGB: OpenRGB Support, and changed rgb matrix center to th…
346c3c8 
…e Y key.
@NetUserGet
Keychron C1 RGB: Fix file structure, Remove Rules.mk, fix RGB flags a…
3c2d870 
…nd postions.
@NetUserGet
Keychron C1 RGB: Oops, sorry put my custom keymap in there.
5d31289
@NetUserGet
Keychron C1 RGB: Remove dead code.
b157df9
@NetUserGet
Keychron C1 RGB: Ommit Userspace customizations
465d248
@NetUserGet
Keychron C1 RGB: Fix minor LED postioning error.
d67b78e
@NetUserGet
Keychron C1 RGB: Remove custom keycodes for rebooting the keyboard in…
fc2ab90 
… favor for the built-in reboot keycode, and rename c1.c to rgb.c
@NetUserGet
Keychron C1 RGB: Make rgb.c more readable
f26958c
@NetUserGet
Keychron C1 RGB: Added VIA support, updated keymap.c, keyboard.json, …
e0631ea 
…and readme.md.
@NetUserGet
Keychron C1 RGB: Add c1_rgb_via.json
c4a83da
@NetUserGet
Keychron C1 RGB: Patch timetravel.
d979d05
@NetUserGet
Keychron C1 RGB: Wrap suppend_power_down_kb and suppend_wakeup_init_k…
c0eb5b9 
…b with an RGB_MATRIX_ENABLE ifdef.
@NetUserGet
Keychron C1 RGB: Remove Keychron and append RGB in keyboard.json unde…
828d1b1 
…r keyboard_name and swap RGB_MATRIX_ENABLE with RGB_MATRIX_SLEEP in rgb.c
@NetUserGet
Keychron C1 RGB: Move some funtions into their respective ifdef state…
05c0434 
…ments.
@NetUserGet
Keychron C1 RGB: change the VID and PID because defaults are owned by…
9c0661a 
… apple.
@NetUserGet
Keychron C1 RGB: Change Q_RESET to QK_BOOT because Q_RESET doesn't work.
1991754
@NetUserGet
Keychron C1 RGB: Personal Prefrence Stuff
2dbf6f3
@NetUserGet
Keychron C1 RGB: Currently fixing issues with layers hold on to somet…
2306bef 
…hing
@NetUserGet
Keychron C1 RGB: What is happening with layers :(
9fa827d
@NetUserGet
Issue after issue
bdaf322
@NetUserGet
Keychron C1 RGB: Layers like an oninon or a painting (Fixed layers)
53e3422
@NetUserGet
Keychron C1 RGB: Oops touched something I wasn't supposed to.
375d687
@NetUserGet
Keychron C1 RGB: Layer state is a bitmap.
90a8405
@NetUserGet
Keychron C1 RGB: Remove the hacky bootm stuff
e6286e7
@NetUserGet
Keychron C1 RGB: Remove DF() in via keymap (it seems broken)
c835916
@NetUserGet
Keychron C1 RGB: add bootloader instructions to info.json
8240907
@NetUserGet
Keychron C1 RGB: Fix the mac keymap, and remove a notice from README.md
93dfd45
@dexter93
Copy link

please resolve conflicts

@dexter93 dexter93 added the rebase-needed New keyboard inclusions are accepted in sn32_develop branch now label Sep 19, 2024
@dexter93 dexter93 merged commit 55325f7 into SonixQMK:sn32_develop Oct 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
keyboard keymap rebase-needed New keyboard inclusions are accepted in sn32_develop branch now via
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NetUserGet @dexter93