Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add RK61 RGB dual mode & RK68 RGB dual mode keyboards #363

Merged
merged 28 commits into from
Nov 22, 2023
Merged

[Keyboard] Add RK61 RGB dual mode & RK68 RGB dual mode keyboards #363

merged 28 commits into from
Nov 22, 2023

Conversation

fpb
Copy link

@fpb fpb commented Nov 18, 2023

Description

Support for RGB Dual mode variants of the RK61 and RK68.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

dexter93
dexter93 requested changes Nov 18, 2023
View reviewed changes
Copy link

@dexter93 dexter93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first pass on review. covering RK61, but notes apply to both keyboards

keyboards/royal_kludge/rk61_rgb/config_led.c Outdated Show resolved Hide resolved
keyboards/royal_kludge/rk61_rgb/config_led.c Outdated Show resolved Hide resolved
keyboards/royal_kludge/rk61_rgb/config_led.h Outdated Show resolved Hide resolved
keyboards/royal_kludge/rk61_rgb/config_led.h Outdated Show resolved Hide resolved
keyboards/royal_kludge/rk61_rgb/info.json Outdated Show resolved Hide resolved
keyboards/royal_kludge/rk61_rgb/keymaps/via/config.h Outdated Show resolved Hide resolved
keyboards/royal_kludge/rk61_rgb/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/royal_kludge/rk61_rgb/config_led.h Outdated Show resolved Hide resolved
fpb and others added 13 commits November 18, 2023 18:46
@fpb
Moved RGB coords and flags into info.json
4373488
@fpb
Removed unnecessary define for maximum brightness (default value is i…
981dc6a 
…dentical)
@fpb @dexter93
Update keyboards/royal_kludge/rk61_rgb/config_led.h
140aa94 
Removed outdated defines not needed.

Co-authored-by: dexter93 <d3xter93@gmail.com>
@fpb
Removed outdated defines not needed.
432d46d
@fpb
Removed NKRO force option
edb1db0
@fpb
Removed leftover flag
3a1c005
@fpb
Updated license header and added missing one
facd0e9
@fpb
Removed empty VIA layers as they are automatically added.
40a6bb3
@fpb @dexter93
Update keyboards/royal_kludge/rk61_rgb/config_led.h
94e3096 
Removed obsolete flags.

Co-authored-by: dexter93 <d3xter93@gmail.com>
@fpb
Moved Led coords and flags into info.json
67fc2c9
@fpb
Merge branch 'sn32_develop' of https://github.com/fpb/qmk_firmware in…
b545a39 
…to sn32_develop
@fpb
Cleanup
74ed356
@fpb
Moved _user function into keymaps. Small corrections
fe769ba
@fpb
Copy link
Author

fpb commented Nov 19, 2023

I believe everything is working now.

@fpb fpb closed this Nov 19, 2023
@fpb fpb reopened this Nov 19, 2023
@fpb fpb requested a review from dexter93 November 19, 2023 04:05
dexter93
dexter93 requested changes Nov 19, 2023
View reviewed changes
keyboards/royal_kludge/rk61_rgb/config_led.h Outdated Show resolved Hide resolved
keyboards/royal_kludge/rk61_rgb/config_led.c Outdated Show resolved Hide resolved
keyboards/royal_kludge/rk61_rgb/keymaps/via/config.h Outdated Show resolved Hide resolved
keyboards/royal_kludge/rk61_rgb/rules.mk Outdated Show resolved Hide resolved
keyboards/royal_kludge/rk68_rgb/config_led.c Outdated Show resolved Hide resolved
keyboards/royal_kludge/rk68_rgb/keymaps/via/config.h Show resolved Hide resolved
keyboards/royal_kludge/rk68_rgb/rules.mk Outdated Show resolved Hide resolved
keyboards/royal_kludge/rk68_rgb/config_led.h Outdated Show resolved Hide resolved
keyboards/royal_kludge/rk68_rgb/keymaps/via/rules.mk Outdated Show resolved Hide resolved
fpb and others added 3 commits November 19, 2023 22:41
@fpb
More cleanup
a96a0ab
@fpb @dexter93
Update keyboards/royal_kludge/rk68_rgb/rules.mk
69c15a8 
removing file no longer needed

Co-authored-by: dexter93 <d3xter93@gmail.com>
@fpb
Code cleanup
17e917d
@fpb fpb requested a review from dexter93 November 19, 2023 23:12
@dexter93 dexter93 changed the title Adding support for RK61 RGB dual mode and RK68 RGB dual mode keyboards with HFD2201KBA chip (Sonic SN32F248B clone) [Keyboard] Add RK61 RGB dual mode & RK68 RGB dual mode keyboards Nov 21, 2023
@dexter93 dexter93 merged commit 7e8abdb into SonixQMK:sn32_develop Nov 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dexter93 dexter93 dexter93 requested changes

Assignees
No one assigned
Labels
keyboard keymap via
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpb @dexter93