-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] [MER-4132] Reimplement authors invite functionality #5337
Draft
nicocirio
wants to merge
20
commits into
master
Choose a base branch
from
MER-4132-reimplement-authors-invite-functionality
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[FEATURE] [MER-4132] Reimplement authors invite functionality #5337
nicocirio
wants to merge
20
commits into
master
from
MER-4132-reimplement-authors-invite-functionality
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still pending:
Fix
Invite New Authors
linkAlready done:
Link to the ticket
As discussed in the main ticket, this PR also introduced the
:pending_confirmation
and:rejected
statuses for and project collaborator (authors_projects
table), to allow the author to decide between accepting/rejecting the invitation (in the previous version the author was directly added to the project and the email invitation ended up being an information email)So, the project's overview page was expanded to allow the author to see the collaborators' possible statuses (rejected, accepted, or pending confirmation).
On the other hand, now the course author workspace won't show the project until the author ends up accepting the invitation (in a future iteration we might want to show a pending confirmation project as "grayed" with a link to the AuthorsInvite liveview)
A non-existing author invitation flow
non_existing_author.mov
An existing author invitation flow (not logged in -> password must be provided)
existing_author_not_signed_in.mov
An existing author invitation flow (logged in with the same account as the invitation)
Since the author is already logged in, the author invitation is confirmed and the author gets redirected to the project as soon as he/she clicks the "Accept" button
existing_author_signed_in.mov
An existing author invitation flow (logged in with a different account than the invitation)
The author sees a warning and will be logged in with the account corresponding to the invitation
existing_author_with_another_account_logged_in.mov
An already rejected invitation
<img width="1434" alt="rejected_invitation" src="https://github.com/user-attac
An already accepted invitation
hments/assets/0ac0ad3c-4f8f-4b48-8b0a-3d95bb96c79b" />A non-existing invitation
Collaborator invitation's statuses on the Project Overview page