Refactor tests and add tox #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollmer
reviewed
Jan 2, 2025
ollmer
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tox allows us to easily run pytest against multiple Python versions to ensure compatibility. With this PR, we identified that the core functionality of TapeAgents is also compatible with Python 3.11 and 3.12 (official support is 3.10). However, there are dependency issues when upgrading to Python 3.13.
The test refactoring aligns the tests with their required dependencies:
Mypy comes easily with tox, maybe pyright would be a better fit, that will be finish in another PR.