Remove empty lines if a custom stack trace parser returns null, fixes #…

…1925
Seldaek · Dec 5, 2024 · 0745038 · 0745038
1 parent 5958473
commit 0745038
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/Monolog/Formatter/LineFormatter.php b/src/Monolog/Formatter/LineFormatter.php
@@ -309,6 +309,6 @@ private function stacktracesParser(\Throwable $e): string
 
     private function stacktracesParserCustom(string $trace): string
     {
-        return implode("\n", array_filter(array_map($this->stacktracesParser, explode("\n", $trace)), fn ($line) => $line !== false && $line !== ''));
+        return implode("\n", array_filter(array_map($this->stacktracesParser, explode("\n", $trace)), fn ($line) => is_string($line) && trim($line) !== ''));
     }
 }
diff --git a/tests/Monolog/Formatter/LineFormatterTest.php b/tests/Monolog/Formatter/LineFormatterTest.php
@@ -193,10 +193,9 @@ public function testDefFormatWithExceptionAndStacktraceParserEmpty()
         });
 
         $message = $formatter->format($this->getRecord(Level::Critical, context: ['exception' => new \RuntimeException('Foo')]));
-
         $trace = explode('[stacktrace]', $message, 2)[1];
-
         $this->assertStringNotContainsString('#', $trace);
+        $this->assertSame(PHP_EOL . PHP_EOL . '"} []' . PHP_EOL, $trace);
     }
 
     public function testDefFormatWithPreviousException()