Work around world age error for Duals in exp_generic #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generated functions that causes world age errors in exp_pade_p if the function has been called before ForwardDiff was loaded.
|
Please hold off a bit. I need to define the zero branch differently since |
|
Fixed it so I believe this one should be good to go. |
vtjnash
reviewed
Aug 16, 2020
| N = randn(n, n) | ||
| @test exp(N) ≈ exp_generic(N) | ||
|
|
||
| exp(n) ≈ exp_generic(n) | ||
| end | ||
| end | ||
|
|
||
| # The issue was only triggered if exp_generic had been called before loading |
There was a problem hiding this comment.
This should be incorrect. What matters is the load order, while it's a bug if the call order is observable.
There was a problem hiding this comment.
how'd you find this? 😆 I think we can just straight avoid the issue for the most common case (#45) and handle the more general thing later.
|
Superseded by #45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and fix
exp_generic(0.0).Closes #42 but not really #41. It's more a temporary workaround than an actual fix. I'm not sure how to fix the problem in full generality.