[Pheonix Subs] Fix AK creation in ui/test_activationkey.py

[ColeHiggins2]

Problem Statement

Since 6.17 Activation keys create and update ops need both - CV and LCE, or none of them.
This new reality broke a couple of tests.

Solution

This PR fixes UI tests in activationkey.py

Related Issues

SAT-28577

[ColeHiggins2]

trigger: test-robottelo
pytest: tests/foreman/ui/test_activationkey.py -k test_positive_add_host

[Satellite-QE]

PRT Result

Build Number: 3
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_activationkey.py -k test_positive_add_host --external-logging
Test Result : ========== 50 deselected, 63 warnings, 9 errors in 1643.61s (0:27:23) ==========

[ColeHiggins2]

trigger: test-robottelo
pytest: tests/foreman/ui/test_activationkey.py::test_positive_add_host

[Satellite-QE]

PRT Result

Build Number: 4
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_activationkey.py::test_positive_add_host --external-logging
Test Result : ================= 12 warnings, 8 errors in 1189.76s (0:19:49) ==================

[Satellite-QE]

PRT Result

Build Number: 9807
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_activationkey.py -k test_positive_add_host --external-logging
Test Result : ==== 1 failed, 7 passed, 50 deselected, 1477 warnings in 8802.56s (2:26:42) ====

[Satellite-QE]

PRT Result

Build Number: 9808
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_activationkey.py::test_positive_add_host --external-logging
Test Result : ================= 7 passed, 783 warnings in 6377.36s (1:46:17) =================

[vsedmik]

One proposal, otherwise looks good to me.

[vsedmik]

It looks the test fails with "errors":["Pending tasks detected in repositories of this content view.
because there is the Metadata generate task running in the background after repo creation.

Could you use wait_for_task instead of sleep(5)? Though the sleep works now it may not be enough in future, IMHO we should better wait for the dependant background task before proceeding with publish.

You can do this

Suggested change

	sleep(5)
	module_target_sat.wait_for_tasks(
	search_query='Actions::Katello::Repository::MetadataGenerate'
	f' and resource_id = {repo.id}'
	' and resource_type = Katello::Repository',
	max_tries=6,
	search_rate=10,
	)

or better, throw it into a fixture together with the repo creation like here, so you don't duplicate code for the other sleep.

[pondrejk]

ack pending existing comments

[vijaysawant]

Ack
Plus one to use of 'wait for metadata generation tasks'.

[chris1984]

ACK, pending comments from @vsedmik

[LadislavVasina1]

ACK, pending vsedmik`s comment