Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix endpoint context comparison #74

Merged

Conversation

SandPod
Copy link
Owner

@SandPod SandPod commented Nov 25, 2024

Patch to existing PR that fixes an issue where detecting endpoint definition changes did not work as expected.

Pre-launch Checklist

  • I read the Contribute page and followed the process outlined there for submitting PRs.
  • This update contains only one single feature or bug fix and nothing else. (If you are submitting multiple fixes, please make multiple PRs.)
  • I read and followed the Dart Style Guide and formatted the code with dart format.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///), and made sure that the documentation follows the same style as other Serverpod documentation. I checked spelling and grammar.
  • I added new tests to check the change I am making.
  • All existing and new tests are passing.
  • Any breaking changes are documented below.

If you need help, consider asking for advice on the discussion board.

Breaking changes

None - modification to new behavior.

@SandPod SandPod marked this pull request as ready for review November 25, 2024 12:23
@SandPod SandPod force-pushed the fix-endpoint-context-comparison branch from b500922 to 38d086a Compare November 25, 2024 12:44
Copy link

@Isakdl Isakdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SandPod SandPod merged commit 43f5428 into use-statefull-analyzers-and-generators Nov 25, 2024
1 check failed
@SandPod SandPod deleted the fix-endpoint-context-comparison branch November 25, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants