Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with numpy 2.0 #109

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Compatibility with numpy 2.0 #109

merged 2 commits into from
Sep 4, 2024

Conversation

niksirbi
Copy link
Member

@niksirbi niksirbi commented Sep 4, 2024 •
edited
Loading

Closes #107

  • Replaces the deprecated np.alltrue with np.all to be compatible with numpy 2.0.
  • Also adds a linting rule that should catch any numpy 2.0 incompatibilities in the future.

Merging this PR is required for unblocking all other open PRs, including #101 and #108.

@niksirbi niksirbi marked this pull request as ready for review September 4, 2024 07:02
@niksirbi niksirbi requested a review from adamltyson September 4, 2024 07:02
@adamltyson adamltyson merged commit ea1f17e into main Sep 4, 2024
17 checks passed
@adamltyson adamltyson deleted the numpy-2compatibility branch September 4, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamltyson adamltyson adamltyson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to numpy 2.0
2 participants
@niksirbi @adamltyson