SWC-7186: SRC EntityPageTitleBar updates on mobile #1503
+69
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adam's quick design: The icons in the design above are grey but I kept mine as the default color as changing the icon color to grey.700 in ComplexMenu will cause that to apply to some other icons in the page if that's ok. |
nickgros
approved these changes
Jan 16, 2025
Comment on lines
+51
to
+58
| sx={theme => ({ | ||
| [theme.breakpoints.down('sm')]: { | ||
| flexDirection: 'column', | ||
| }, | ||
| [theme.breakpoints.up('sm')]: { | ||
| flexDirection: 'row', | ||
| }, | ||
| })} |
There was a problem hiding this comment.
Same but more concise
Suggested change
| sx={theme => ({ | |
| [theme.breakpoints.down('sm')]: { | |
| flexDirection: 'column', | |
| }, | |
| [theme.breakpoints.up('sm')]: { | |
| flexDirection: 'row', | |
| }, | |
| })} | |
| sx={{ | |
| flexDirection: { xs: 'column', sm: 'row' } | |
| })} |
| alignItems: 'center', | ||
| gap: '10px', | ||
| [theme.breakpoints.down('sm')]: { | ||
| flexWrap: 'wrap', |
There was a problem hiding this comment.
Would it make more sense to change the flex-direction to column here instead of making it wrap?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://sagebionetworks.jira.com/browse/SWC-7186?atlOrigin=eyJpIjoiZmRhODg4MjIyYmU3NGRhYjk1ODU5MTcxNDM1NTg2YmIiLCJwIjoiaiJ9